Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the DisplayManager class to directly import and use the logging module instead of accepting it as a constructor dependency, simplifying the class interface.
- Removed log parameter from DisplayManager constructor
- Added direct import of electron-log/main.js to DisplayManager
- Updated all test cases to reflect the simplified constructor
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/utils/displayManager.js | Imports electron-log directly and removes log parameter from constructor |
| app/main.js | Removes log parameter when instantiating DisplayManager |
| test/displayManager.js | Updates all test cases to use simplified constructor and removes logging mock setup |
Comment on lines
+5
to
6
| constructor (settings) { | ||
| this.settings = settings |
There was a problem hiding this comment.
The change from dependency injection to direct import reduces testability and makes the DisplayManager class tightly coupled to the electron-log module. Consider keeping the log parameter optional to maintain flexibility for testing while providing a default import.
Suggested change
| constructor (settings) { | |
| this.settings = settings | |
| constructor (settings, logInstance = log) { | |
| this.settings = settings | |
| this.log = logInstance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.